Repository navigation
fix(tags): display selected tag in settings - #63508
Conversation
joshtrichards
added
bug
3. to review
|
/backport to stable34 |
| :placeholder="t('systemtags', 'Collaborative tags …')" | ||
| :fetchTags="false" | ||
| :options="tags" | ||
| :limit="null" |
There was a problem hiding this comment.
That will cause type issues - either now or in the future at least.
Because limit is typed as number not number|null.
So either pass a real limit as number or do not pass limit meaning taking the default.
Otherwise if you need "all tags" then this needs a fix in the library allowing to pass null or 0
There was a problem hiding this comment.
Hmm. Implementation docs says otherwise - and I'm fairly certain I found this usage somewhere else already in production:
But I guess maybe you're right:
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
logic is fine - component documentation just wrong
The "Search for a tag to edit" field should show the selected tag as the selected option. It fails to do so because the object is passed instead of just the id. Signed-off-by: Josh <josh.t.richards@gmail.com>
d521f7c to
c9c4627
Compare
|
/backport to stable34 |
|
The backport to # Switch to the target branch and update it
git checkout stable34
git pull origin stable34
# Create the new backport branch
git checkout -b backport/63508/stable34
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c9c4627a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/63508/stable34Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/63508/stable34."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable35 |
Resolves: #Summary
The "Search for a tag to edit" field should display the selected tag, but it continues to show the placeholder after a tag is selected. It fails to do so because the object is passed instead of just the ID.
NcSelectTagsuses ID-based model values by default (passthruis false).onSelectTag()expects the numeric ID and resolves it againstprops.tags.This change passes the selected tag's ID instead, or
nullwhen no tag is selected:NcSelectTagsmatches the component's expected model format; andonSelectTag()handler remain consistent.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)